Re: [patch 6/7] sched: change nohz.load_balancer to be nr_cpu_idsbased

From: Peter Zijlstra
Date: Thu May 20 2010 - 05:50:17 EST


On Mon, 2010-05-17 at 11:27 -0700, Suresh Siddha wrote:
> int get_nohz_load_balancer(void)
> {
> - return atomic_read(&nohz.load_balancer);
> + int load_balancer = atomic_read(&nohz.load_balancer);
> + if (load_balancer >= nr_cpu_ids)
> + return nr_cpu_ids;
> +
> + return load_balancer;
> }

How could it ever be > nr_cpu_ids, and thus, do we need that
conditional?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/