Re: [PATCH] sched: fix updating sd->balance_interval inidle_balance()

From: Peter Zijlstra
Date: Thu May 20 2010 - 03:17:19 EST


On Wed, 2010-05-19 at 16:45 -0700, Nikhil Rao wrote:
> sd->balance_interval is updated incorrectly when SD_BALANCE_NEWIDLE is not set
> in sd->flags. This patch updates sd->balance_interval only when we balance the
> domain.

I really need more than that.

Why is it wrong, what are the (measurable) effects of changing it and
how did it come to be this way.

I could of course go and try to reverse engineer your patch, but it
would be awesome if I didn't have to.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/