Re: [PATCH] scheduler: Extract cgroups_cpuaccount code fromsched.c into own file

From: Peter Zijlstra
Date: Wed May 19 2010 - 06:28:40 EST

On Wed, 2010-05-19 at 11:37 +0200, Peter Zijlstra wrote:
> On Wed, 2010-05-19 at 11:30 +0200, Thomas Renninger wrote:
> >
> > This is a cleanup against current linux-2.6 Linus tree.
> >
> > Having CONFIG_CGROUP_CPUACCT code in kernel/sched.c looks wrong.
> > Move this out to kernel/cgroup_cpuaccount.c
> >
> > Test compiled with and without CONFIG_CGROUP_CPUACCT set on x86_64.
> Sure, works for me, less code to look at :-)

In file included from /mnt/build/linux-2.6/kernel/sched.c:1908:
/mnt/build/linux-2.6/kernel/sched_fair.c: In function âupdate_currâ:
/mnt/build/linux-2.6/kernel/sched_fair.c:544: error: implicit declaration of function âcpuacct_chargeâ
CC kernel/sysctl_binary.o
/mnt/build/linux-2.6/kernel/sched.c: In function âaccount_user_timeâ:
/mnt/build/linux-2.6/kernel/sched.c:3265: error: implicit declaration of function âcpuacct_update_statsâ
/mnt/build/linux-2.6/kernel/sched.c:3265: error: âCPUACCT_STAT_USERâ undeclared (first use in this function)
/mnt/build/linux-2.6/kernel/sched.c:3265: error: (Each undeclared identifier is reported only once
/mnt/build/linux-2.6/kernel/sched.c:3265: error: for each function it appears in.)
/mnt/build/linux-2.6/kernel/sched.c: In function âaccount_system_timeâ:
/mnt/build/linux-2.6/kernel/sched.c:3332: error: âCPUACCT_STAT_SYSTEMâ undeclared (first use in this function)
make[2]: *** [kernel/sched.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [kernel/] Error 2
make: *** [sub-make] Error 2

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at