Re: [PATCH] mfd: new AB8500 driver

From: Samuel Ortiz
Date: Sun May 16 2010 - 18:53:27 EST

Hi Rabin,

On Tue, May 11, 2010 at 10:15:31AM +0530, Rabin Vincent wrote:
> Add a new driver to support the AB8500 Power Management chip, replacing
> the current AB4500. The new driver replaces the old one, instead of an
> incremental modification, because this is a substantial overhaul
> including:
> - Split of the driver into -core and -spi portions, to allow another
> interface layer to be added
> - Addition of interrupt support
> - Switch to MFD core API for handling subdevices
> - Simplification of the APIs to remove a redundant block parameter
> - Rename of the APIs and macros from ab4500_* to ab8500_*
> - Rename of the files from ab4500* to ab8500*
> The driver still identifes itself as "ab4500"
The patch looks good, but why not changing that to "ab8500" and integrating
the relevant board file changes to this patch ?


Intel Open Source Technology Centre
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at