Re: [PATCH] w35und: fix usb_control_msg() error handling in wb35_probe()

[Pekka Enberg]

On Mon, Jan 26, 2009 at 8:03 PM, Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:
> Greg KH wrote:
>>
>> On Thu, Jan 22, 2009 at 12:06:33PM +0200, Pekka J Enberg wrote:
>>>
>>> From: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
>>>
>>> If successful, the usb_control_msg() function returns the number of
>>> bytes transferred. Fix up wb35_probe() to only bail out if the function
>>> returns a negative number.
>>>
>>> Reported-by: Sandro Bonazzola <sandro.bonazzola@xxxxxxxxx>
>>> Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
>>
>> I'm confused, should I apply this patch or not?
>
> Yes, you should. What's confusing you here?

Oh, looking at the thread, I see how you got confused. The patch
doesn't fix all of Sandro's problems but is an obvious improvement so
it should be merged.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/