Re: [PATCH v2] Add Dallas DS1390 RTC chip

From: Mark Jackson
Date: Mon Oct 20 2008 - 07:54:00 EST

Alessandro Zummo wrote:
On Mon, 20 Oct 2008 09:41:18 +0100
Mark Jackson <mpfj@xxxxxxxxxx> wrote:

+struct ds1390 {
+ struct rtc_device *rtc;
+ u8 buf[9]; /* cmd + 8 registers */
+ u8 tx_buf[2];
+ u8 rx_buf[2];

don't we still have too many buffers?

Ah yes ... ooops !!

the use of bin2bcd an bcd2bin (lowercase) would also be appreciated.

Will do.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at