Re: [PATCH v2] Add Dallas DS1390 RTC chip

[Alessandro Zummo]

On Mon, 20 Oct 2008 09:41:18 +0100
Mark Jackson <mpfj@xxxxxxxxxx> wrote:

> +struct ds1390 {
> +	struct rtc_device *rtc;
> +	u8 buf[9];	/* cmd + 8 registers */
> +	u8 tx_buf[2];
> +	u8 rx_buf[2];
> +};
> +

 don't we still have too many buffers?

 the use of bin2bcd an bcd2bin (lowercase) would also be appreciated.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/