Re: [crash] BUG: unable to handle kernel NULL pointer dereferenceat 0000000000000370

From: Patrick McHardy
Date: Mon Jul 21 2008 - 18:05:39 EST

Larry Finger wrote:
Patrick McHardy wrote:

This is what I was missing, we're setting a lockdep class
by default depending on dev->type. This patch combined
with yours should fix all addr_list_lock warnings.

No cigar yet. I tried davem's patch first, then yours on top of his. I still get both the recursive locking and the kernel warning.

Does this one earn me my cigar? :)

diff --git a/net/core/dev.c b/net/core/dev.c
index 2eed17b..371b1a0 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -259,7 +259,7 @@ static RAW_NOTIFIER_HEAD(netdev_chain);

DEFINE_PER_CPU(struct softnet_data, softnet_data);

* register_netdevice() inits txq->_xmit_lock and sets lockdep class
* according to dev->type