Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATMdriver to request_firmware()

[David Woodhouse]

On Thu, 2008-06-05 at 12:06 -0400, Chas Williams (CONTRACTOR) wrote:
> yes, it is troubling.  along the same lines, this patch removes the
> pca200e/sba200e firmware from the kernel.  the firmware will be in the
> next release of the userspace atm tools.  i could move the ambassador
> firmware there as well if you would like.

Sorry for dropping this; I'll let it go through the net tree now it's
there.

A couple of comments though... it looks like you forgot to add
MODULE_FIRMWARE(). And shouldn't 'fw_data' in
fore200e_load_and_start_firmware() be a (__le32 *) not a (u32 *)?

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/