Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware()

[Chas Williams (CONTRACTOR)]

In message <1214818473.10393.337.camel@xxxxxxxxxxxxxxxxxx>,David Woodhouse writ
es:
>Sorry for dropping this; I'll let it go through the net tree now it's
>there.

ok

>A couple of comments though... it looks like you forgot to add
>MODULE_FIRMWARE(). And shouldn't 'fw_data' in

yes.  i will get davem a patch for that asap.

>fore200e_load_and_start_firmware() be a (__le32 *) not a (u32 *)?

yes, it certainly could be.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/