Re: [PATCH 3/3] x86: fix pcspkr to not use inb_p/outb_p calls.

[Ingo Molnar]

* Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> On Sun, 17 Feb 2008 16:56:42 -0500 (EST)
> "David P. Reed" <dpreed@xxxxxxxx> wrote:
> 
> > Fix pcspkr driver to use explicit timing delay for access to PIT,
> > rather than inb_p/outb_p calls, which use insufficiently explicit
> 
> NAK.
> 
> We now have inb_pit and outb_pit to make the transition easier - can 
> you switch to those instead of coding internal knowledge outside of 
> the kernel methods.

please also Cc: Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx> to 
drivers/input/ patches. Once inb_pit/outb_pit is used, as suggested by 
Alan, i ack the patch from the arch/x86 perspective.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/