Re: [PATCH] x86: Coding style fixes forarch/x86/kernel/cpu/centaur.c

From: Joe Perches
Date: Sun Feb 17 2008 - 22:13:21 EST


On Mon, 2008-02-18 at 03:56 +0100, Ingo Molnar wrote:
> arch/x86/kernel/cpu/centaur.c | 394 +++++++++++++++++++++---------------------
> 1 file changed, 199 insertions(+), 195 deletions(-)
>
> Index: linux-x86.q/arch/x86/kernel/cpu/centaur.c
> ===================================================================
> --- linux-x86.q.orig/arch/x86/kernel/cpu/centaur.c
> +++ linux-x86.q/arch/x86/kernel/cpu/centaur.c
> @@ -52,13 +54,12 @@ static u32 __cpuinit ramtop(void) /* 16
> if (e820.map[i].addr > 0xFFFFFFFFUL)
> continue;
> /*
> - * Don't MCR over reserved space. Ignore the ISA hole
> - * we frob around that catastrophe already
> + * Don't MCR over reserved space. Ignore the ISA hole
> + * we frob around that catastrophe already
> */
> -
> - if (e820.map[i].type == E820_RESERVED)
> - {
> - if (e820.map[i].addr >= 0x100000UL && e820.map[i].addr < clip)
> + if (e820.map[i].type == E820_RESERVED) {
> + if (e820.map[i].addr >= 0x100000UL &&
> + e820.map[i].addr < clip)
> clip = e820.map[i].addr;

Doesn't this look better as:

+ if (e820.map[i].addr >= 0x100000UL &&
+ e820.map[i].addr < clip)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/