Re: [PATCH 3/3] x86: fix pcspkr to not use inb_p/outb_p calls.

From: Alan Cox
Date: Sun Feb 17 2008 - 17:32:45 EST


On Sun, 17 Feb 2008 16:56:42 -0500 (EST)
"David P. Reed" <dpreed@xxxxxxxx> wrote:

> Fix pcspkr driver to use explicit timing delay for access to PIT,
> rather than inb_p/outb_p calls, which use insufficiently explicit

NAK.

We now have inb_pit and outb_pit to make the transition easier - can you
switch to those instead of coding internal knowledge outside of the
kernel methods.

They in turn will acquire whatever logic is needed to DTRT.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/