Re: [PATCH] Linux Kernel Markers 0.14 for 2.6.17

[Jeremy Fitzhardinge]

Mathieu Desnoyers wrote:
> Hi,
>
> Constructing on Jeremy Fitzhardinge's comments about gcc optimizations, I
> rewrote (once more) the markers mechanism so that the optimized mode does not
> jump between two different inline asm. Instead, the optimized version uses a
> load immediate (in assembly) that will be used by a test to decide of a branch
> (in C).
>   

I should have spelled out my point a bit more.  If you've got a flag 
you're just testing, couldn't you just do:

	if (__mark_enabled_##name)
		(*__mark_func)(...);

and do without the asms or the section?

The section will still be useful for simply labelling the mark sites, 
but if you want to call something there, you don't need it.

   J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/