Re: [Patch 1/2] CPU hotplug compatible alloc_percpu

From: Martin Peschke
Date: Fri Jul 28 2006 - 02:13:23 EST

Paul Jackson wrote:
Martin wrote:
+static inline int percpu_populate_mask(void *__pdata, size_t size, gfp_t gfp,
+ int cpu)

It seems odd to me that this signature of percpu_populate_mask()
has its last argument 'int cpu' for the !CONFIG_SMP case, but
the SMP signatures have 'cpumask_t mask'.

Shouldn't this function signature be the same for all CONFIG's?

Looks like a mistake. Luckily, it won't cause any harm, though.
I will send a patch.

Thank you for reviewing.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at