Re: [Patch 1/2] CPU hotplug compatible alloc_percpu

From: Paul Jackson
Date: Thu Jul 27 2006 - 12:17:32 EST

Martin wrote:
> +static inline int percpu_populate_mask(void *__pdata, size_t size, gfp_t gfp,
> + int cpu)
> +{

It seems odd to me that this signature of percpu_populate_mask()
has its last argument 'int cpu' for the !CONFIG_SMP case, but
the SMP signatures have 'cpumask_t mask'.

Shouldn't this function signature be the same for all CONFIG's?

I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.925.600.0401
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at