Re: XFS / Quota Bug in 2.6.17.x and 2.6.18x

From: Nathan Scott
Date: Thu Jul 27 2006 - 19:41:43 EST


Hi Stefan,

On Thu, Jul 27, 2006 at 01:39:29PM +0200, ProfiHost - Stefan Priebe wrote:
> Hello!
>
> The crash only occurs if you use quota and IDE without barrier support.
>
> The Problem is, that on a new mount of a root filesystem - the flag
> VFS_RDONLY is set - and so no barrier check is done before checking
> quota. With this patch barrier check is done always. The partition
> should not be mounted at that moment. For mount -o remount, rw or
> something like this it uses another function where VFS_RDONLY is checked.

Ah, I see. The patch isn't quite right, I think we will now need to
also add a test to xfs_mountfs_check_barriers() to ensure the device
beneath us is not bdev_read_only().

I'll add that and get the fix merged, thanks.

cheers.

--
Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/