Re: [patch] Reorganize the cpufreq cpu hotplug locking to not be totally bizare

From: Srivatsa Vaddagiri
Date: Wed Jul 26 2006 - 17:04:54 EST

On Wed, Jul 26, 2006 at 01:22:24PM -0700, Linus Torvalds wrote:
> I wonder if we could just make the workqueue code just run with preemption
> disabled - that should also automatically protect against any CPU hotplug
> events on the local CPU (and I think "local CPU" is all that the wq code
> cares about, no?)

__create_workqueue(), destroy_workqueue() and flush_workqueue() are all
taking CPU hotplug lock currently. AFAICS they all can block and so
disabling preemption wont work. What am I missing?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at