Re: Slab corruption in 2.6.16-rc5-mm2

[Andrew Morton]

Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
>
> Chuck Ebbert wrote:
> > In-Reply-To: <Pine.LNX.4.64.0603061917330.3573@xxxxxxxxxxx>
> > 
> > On Mon, 6 Mar 2006 19:20:13 -0800, Linus Torvalds wrote:
> > 
> > 
> >>>When someone converted the *buffer* allocation to kzalloc they
> >>>also removed the the memset for the *packet_cmmand* struct.
> >>>
> >>>The
> >>>
> >>>memset(&cgc, 0, sizeof(struct packet_command));
> >>>
> >>>should be added back I think.
> >>
> >>Good eyes. I bet that's it.
> > 
> > 
> > Heh.  This exact fix was posted to linux-kernel by Lee Schermerhorn
> > three weeks ago:
> > 
> >  Date: Wed, 15 Feb 2006 14:07:37 -0500
> >  From: Lee Schermerhorn <lee.schermerhorn@xxxxxx>
> >  Subject: [PATCH] 2.6.16-rc3-mm1 - restore zeroing of packet_command
> >         struct  in sr_ioctl.c
> >  To: linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>
> >  Cc: Andrew Morton <akpm@xxxxxxxx>
> >  Message-ID: <1140030457.6619.3.camel@xxxxxxxxxxxxxxxxxxxxx>
> > 
> > 
> 
> It isn't Andrew's job to make sure a patch gets to the right place
> until it is safely in -mm, and even then he's not always going to
> know the severity and importance unless he's told.

Is too!

> If it was a patch to "restore" a regression in behaviour, CCs should
> at least have gone to the author of the patch that broke it, and the
> subsystem maintainers / list / etc as well.

I actually merged Lee's patch into -mm, copied James on it and then I
dropped it when I saw that it spat rejects against an updated version of
James's tree, assuming that it had been merged.

Often I'll check that a patch reverts successfully from the upstream tree
before dropping it, but for an obvious one like that I guess I didn't
bother, and assumed that James had taken it.  Only he hadn't - instead he'd
gone and merged something else, hence the rejects.   Oh well.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/