Re: Slab corruption in 2.6.16-rc5-mm2

[Nick Piggin]

Chuck Ebbert wrote:
> In-Reply-To: <Pine.LNX.4.64.0603061917330.3573@xxxxxxxxxxx>
>
> On Mon, 6 Mar 2006 19:20:13 -0800, Linus Torvalds wrote:
>
>
> > > When someone converted the *buffer* allocation to kzalloc they
> > > also removed the the memset for the *packet_cmmand* struct.
> > >
> > > The
> > >
> > > memset(&cgc, 0, sizeof(struct packet_command));
> > >
> > > should be added back I think.
> >
> > Good eyes. I bet that's it.
>
>
> Heh.  This exact fix was posted to linux-kernel by Lee Schermerhorn
> three weeks ago:
>
>  Date: Wed, 15 Feb 2006 14:07:37 -0500
>  From: Lee Schermerhorn <lee.schermerhorn@xxxxxx>
>  Subject: [PATCH] 2.6.16-rc3-mm1 - restore zeroing of packet_command
>         struct  in sr_ioctl.c
>  To: linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>
>  Cc: Andrew Morton <akpm@xxxxxxxx>
>  Message-ID: <1140030457.6619.3.camel@xxxxxxxxxxxxxxxxxxxxx>

It isn't Andrew's job to make sure a patch gets to the right place
until it is safely in -mm, and even then he's not always going to
know the severity and importance unless he's told.

If it was a patch to "restore" a regression in behaviour, CCs should
at least have gone to the author of the patch that broke it, and the
subsystem maintainers / list / etc as well.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/