Re: i386 entry.S problems

From: Jan Beulich
Date: Mon Sep 27 2004 - 04:51:16 EST


>>> Christoph Hellwig <hch@xxxxxxxxxxxxx> 27.09.04 11:00:18 >>>
>On Mon, Sep 27, 2004 at 09:37:10AM +0200, Jan Beulich wrote:
>> >>> Christoph Hellwig <hch@xxxxxxxxxxxxx> 24.09.04 21:12:51 >>>
>> >> +#if !defined(CONFIG_REGPARM) || __GNUC__ < 3
>> >> pushl %ebp
>> >> +#endif
>> >
>> >CONFIG_REGPARM n eeds gcc 3.0 or later
>>
>> Not sure what you try to point out here: the additions account for
>> exactly that.
>
>No, the || __GNUC__ < 3 is superflous. if CONFIG_REGPARM is defined
>and __GNUC__ < 3 you have problems elsewhere already.

I don't think so. Otherwise, why would arch/i386/Makefile specifically
deal with this situation?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/