Re: Stack traces in 2.6.9-rc2-mm4

[Nick Piggin]

Reuben Farrelly wrote:
> Since upgrading from -mm3 to -mm4, I'm now getting messages like this 
> logged every second or so:
>
> Sep 27 18:28:06 tornado kernel: using smp_processor_id() in preemptible 

snip

> Is there a fix to shut this all up or a suggested patch to revert?
>
> Box is a P4 Intel 2.8Ghz single processor, SMP/HT with PREEMPT on..

Looks like disk_stat_add in the sw-raid code. The proper fix is probably
to disable preempt around those regions - but just doing it the dumb
way (ie. in the driver code) looks like an unfortunate layering violation.

Maybe something like disk_stat_update_start / disk_stat_update_end that
gives you the per-cpu stat pointer as a "token" to be used by
disk_stat_inc/add/etc. Anyone?

Named slightly differently, so you keep backward compatibility, of course.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/