Re: Dealing with swsusp vs. pmdisk

[Nigel Cunningham]

Hi.

On Tue, 2004-03-16 at 13:01, Benjamin Herrenschmidt wrote:
> > - Freezer hooks (I can easily get suspend2 working with the old freezer
> > until people are convinced it's not up to the task). This accounts for
> > the vast majority of those file changes.
> 
> It would be nice if you did that as a first step indeed. I'm personally
> not convinced of the usefullness of having a freezer at all ;)

Without a freezer, how would you ensure that other processes don't mess
up your memory state while you're saving/reloading the image?

> Some of the "guard" code you added to the filesystem is scary too..

It's really just paranoia, particularly for where swapfiles are in use.
While developing the swapfile support, I had a couple of occasions where
I messed up my superblock because of a bug. I'm very confident now that
the suspend code itself is stable and mature, but since the device
drivers aren't there, I'd rather not remove the safety nets just yet.

Nigel
-- 
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (2) 6251 7727(wk); +61 (2) 6253 0250 (home)

Evolution (n): A hypothetical process whereby infinitely improbable events occur 
with alarming frequency, order arises from chaos, and no one is given credit.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/