Re: What's the point of __KERNEL_SYSCALLS__?

From: Alan Cox
Date: Sun Sep 21 2003 - 03:13:42 EST


On Sul, 2003-09-21 at 05:54, Matthew Wilcox wrote:
> On Fri, Sep 19, 2003 at 05:40:44PM +0100, Matthew Wilcox wrote:
> > This doesn't seem like a big list to clean up. Any objections to
> > getting rid of them and making the calls directly?
>
> Here's a patch that removes them for i386 and parisc. Other arches can
> catch up as they see fit. Comments? I've compiled the files that aren't
> completely arch-specific (eg sparc or m68k).

> -static inline int execve(char *filename, char * argv [],
> - char * envp[])
> -{
> - extern int __execve(char *, char **, char **, struct task_struct *);
> - return __execve(filename, argv, envp, current);
> -}

execve on some platforms relies on the entry stuff. Take a look at the
use of the passed registers in sys_execve on x86 as an example. Simply
calling sys_execve won't work. The same is true for sys_clone used to
create threads.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/