Re: [PATCH] Re: Shared memory shmat/dt not working well in

From: Petr Vandrovec (vandrove@vc.cvut.cz)
Date: Tue Oct 01 2002 - 12:56:07 EST


On Tue, Oct 01, 2002 at 06:14:04PM +0100, Hugh Dickins wrote:
> On Tue, 1 Oct 2002, Petr Vandrovec wrote:
> >
> > You are my hero!
>
> Aww, shucks! I guess I'd better have a go at your next problem...
>
> Looks to me like flush_tlb_mm is faulting on the vma->vm_mm given it.
> And looks to me like mprotect_fixup, in the merge case, may be passing
> an already freed vma to change_protection. I'm not as confident about
> this patch as the earlier one, but I believe it's correct: please
> give it a try, and maybe Christoph will confirm or deny it.

Thanks. It fixed my problem (again ;-) ). Maybe I should already asked
yesterday instead of starring at mprotect code.
                                        Many thanks,
                                                Petr Vandrovec
                                                vandrove@vc.cvut.cz
> Hugh
>
> --- 2.5.40/mm/mprotect.c Fri Sep 27 23:56:45 2002
> +++ linux/mm/mprotect.c Tue Oct 1 18:00:31 2002
> @@ -186,8 +186,10 @@
> /*
> * Try to merge with the previous vma.
> */
> - if (mprotect_attempt_merge(vma, *pprev, end, newflags))
> + if (mprotect_attempt_merge(vma, *pprev, end, newflags)) {
> + vma = *pprev;
> goto success;
> + }
> } else {
> error = split_vma(mm, vma, start, 1);
> if (error)
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:27 EST