Re: [patch] 2.5 videodev redesign -- #3

From: Gerd Knorr (kraxel@bytesex.org)
Date: Mon Mar 04 2002 - 04:47:33 EST

Next message: Anthony DeRobertis: "2.4.17 USB problems"
Previous message: Alexander Sandler: "FW: BUG in spinlock.h:133"
In reply to: Oliver Neukum: "Re: [patch] 2.5 videodev redesign -- #3"
Next in thread: Gerd Knorr: "Re: [patch] 2.5 videodev redesign -- #3"
Reply: Gerd Knorr: "Re: [patch] 2.5 videodev redesign -- #3"
Reply: Oliver Neukum: "Re: [patch] 2.5 videodev redesign -- #3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> > Comments? Bugs? I plan to feed this to Linus soon ...
>
> Hi,
>
> it seems to me that you are not holding the BKL during
> the open method of the individual driver. This will
> cause races with unplugging on some USB cameras.

What race exactly?

I don't want videodev.c know details about the devices, it doesn't
belong there. If a usb cam needs locking, the usb cam's open() function
should do that then. I'll prefare fixing the usb drivers instead of
calling driver->open() with BKL held.

Gerd

-- 
#include </dev/tty>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Anthony DeRobertis: "2.4.17 USB problems"
Previous message: Alexander Sandler: "FW: BUG in spinlock.h:133"
In reply to: Oliver Neukum: "Re: [patch] 2.5 videodev redesign -- #3"
Next in thread: Gerd Knorr: "Re: [patch] 2.5 videodev redesign -- #3"
Reply: Gerd Knorr: "Re: [patch] 2.5 videodev redesign -- #3"
Reply: Oliver Neukum: "Re: [patch] 2.5 videodev redesign -- #3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Mar 07 2002 - 21:00:32 EST