Re: [patch] 2.5 videodev redesign -- #3

From: Oliver Neukum (oliver@neukum.org)
Date: Mon Mar 04 2002 - 03:17:54 EST


Am Samstag, 2. März 2002 15:15 schrieb Gerd Knorr:
> Hi,
>
> I've updated the videodev patch set. The core part of the redesign is
> attached below for comments. It is also available here:
> http://bytesex.org/patches/2.5/10_videodev-2.5.6-pre2.diff
>
> The 2.4 version of the patch (which is slightly different because
> it keeps the old stuff for backward compatibility) is here:
> http://bytesex.org/patches/10_videodev-2.4.19-pre2.diff
>
> I've also updated most v4l drivers (including usb cams this time)
> to the new videodev interface. Changes are available as individual,
> per driver patches from:
> http://bytesex.org/patches/2.5/
>
> There is also one big patch with all changes:
> http://bytesex.org/patches/2.5/patch-2.5.6-pre2-kraxel.gz
>
> Comments? Bugs? I plan to feed this to Linus soon ...

Hi,

it seems to me that you are not holding the BKL during
the open method of the individual driver. This will
cause races with unplugging on some USB cameras.

        Regards
                Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Mar 07 2002 - 21:00:32 EST