Re: that stupid aic7xxx AHC_NSEGS bug

From: Justin T. Gibbs (gibbs@scsiguy.com)
Date: Thu Dec 13 2001 - 15:57:43 EST


>
>We simply forget to initialize scb->sg_count in the non use_sg
>case, so if the previous usage of that scb has sg_count==AHC_NSEGS
>then we'd hit that panic erroneously. Here is the fix below.

Which just goes to show you have useful Steve Lord's report was.
Even someone unfamiliar with the driver could figure this out once
someone bothered to provide decend debuggin info.

>"It can't possibly be my driver, something broke in some Linux
>subsystem which is making my driver break", sheesh get over it
>Justin...

That's a bit unfair David, and its also not an acurate quote. I
did say to Nick Pasich, "I guarantee you though, it is not the aic7xxx
driver's fault" on 11/26, but ever since it became apparent that
I was wrong (11/29 perhaps?), I've been working with Nick to try
and reproduce the problem. We all make mistakes David, even you.
Get over it. 8-)

--
Justin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Dec 15 2001 - 21:00:27 EST