Re: [PATCH] v2.5.1-pre9-00_kvec.diff

From: Benjamin LaHaise (bcrl@redhat.com)
Date: Tue Dec 11 2001 - 18:41:09 EST

Next message: Alan Cox: "Re: NULL pointer dereference in moxa driver"
Previous message: Nathan Scott: "Re: Implementing POSIX ACLs - was Re: [PATCH] Revised extended attributes interface"
In reply to: Hugh Dickins: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
Next in thread: Benjamin LaHaise: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Dec 11, 2001 at 11:33:32PM +0000, Hugh Dickins wrote:
> Looks nice, but I think you need to update from atomic_inc(&map->count)
> and __free_page(map) to page_cache_get(map) and page_cache_release(map)?
> I haven't checked a 2.5.1-pre9 tree, but we had to change that in 2.4,
> to avoid PageLRU BUGs. page_cache_get end just tidiness, of course.

Ahhh, that's something I've missed since our internal tree is still 2.4.9-ac
based. Thanks,

-ben

-- 
Fish.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Alan Cox: "Re: NULL pointer dereference in moxa driver"
Previous message: Nathan Scott: "Re: Implementing POSIX ACLs - was Re: [PATCH] Revised extended attributes interface"
In reply to: Hugh Dickins: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
Next in thread: Benjamin LaHaise: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Dec 15 2001 - 21:00:22 EST