Re: 2.4.0test1-ac14: smp deadlock

From: Philipp Rumpf (prumpf@puffin.external.hp.com)
Date: Mon Jun 12 2000 - 07:14:15 EST


On Mon, Jun 12, 2000 at 10:02:38PM +1000, Andrew Morton wrote:
> Philipp Rumpf wrote:
> >
> > ..
> > >From reading del_timer_sync, you're only allowed to use it if you use
> > timer_exit in your timer, like this:
>
> I like your first patch. One little modification:
>
> > --- linux/kernel/sched.c Sun Jun 11 17:02:22 2000
> > +++ linux-prumpf/kernel/sched.c Sun Jun 11 18:43:20 2000
> > @@ -337,15 +337,23 @@
> > spin_unlock_irqrestore(&runqueue_lock, flags);
> > }
> >
> > +struct foo_struct {
> > + struct task_struct *process;
> > + struct timer_list *timer;
> ^
> ^^^
>
> This can be simply 'struct timer_list timer'

Agreed. In fact this makes the UP case be just an additional indirection
instead of wasting any stack space.

Now all we need is a a better name than foo ...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jun 15 2000 - 21:00:25 EST