Re: Patch for PowerPC

• Next message: Jonathan Nicholson: "Re: [Semi-OT,important] ORBS globally blocks users of these lists"
• Previous message: Adam Fritzler: "Re: IBM & Linux"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

pavel_roskin@geocities.com said:
> - Some macros are not constants on PPC and cannot be used after "case".
> Converted to if-else chains.

Then either the cpu_to_le16 macro is buggy, gcc is buggy,
 or we should be using __constant_cpu_to_le16 or some such routine.

I don't think reverting to if-else chains is the right thing to do.

Comments, anyone?

                
- switch(bci.Status) {
- case cpu_to_le16(BLOCK_FREE):
+ if (bci.Status == cpu_to_le16(BLOCK_FREE))
                        thisEUN = 0;
- break;
- case cpu_to_le16(BLOCK_USED):
+ else if (bci.Status == cpu_to_le16(BLOCK_USED))
                        lastgoodEUN = thisEUN;
- break;
- case cpu_to_le16(BLOCK_IGNORE):
- case cpu_to_le16(BLOCK_DELETED):
- break;
- default:
+ else if (bci.Status != cpu_to_le16(BLOCK_IGNORE) &&
+ bci.Status != cpu_to_le16(BLOCK_DELETED))
                        printk("Unknown status for block %d in EUN %d: %x\n",block,thisEUN, bci.Status);
- }
 

--
dwmw2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Jonathan Nicholson: "Re: [Semi-OT,important] ORBS globally blocks users of these lists"
• Previous message: Adam Fritzler: "Re: IBM & Linux"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jan 23 2000 - 21:00:19 EST