Re: 2.3.25pre2: drivers/sound/es1371.c broken

Jens Axboe (axboe@image.dk)
Sun, 31 Oct 1999 02:03:08 +0200


--7AUc2qLy4jB3hD7Z
Content-Type: text/plain; charset=us-ascii

On Sat, Oct 30 1999, Horst von Brand wrote:
> es1371.c: In function `es1371_mmap':
> es1371.c:1897: structure has no member named `vm_offset'
> es1371.c: In function `es1371_mmap_dac':
> es1371.c:2418: structure has no member named `vm_offset'
> es1371.c: At top level:
> es1371.c:3234: warning: `init_es1371' defined but not used
> es1371.c:3260: warning: `cleanup_es1371' defined but not used
> make[2]: *** [es1371.o] Error 1
> make[2]: Leaving directory `/usr/src/linux-2.3.25pre/drivers/sound'
> make[1]: *** [_modsubdir_sound] Error 2
> make[1]: Leaving directory `/usr/src/linux-2.3.25pre/drivers'
> make: *** [_mod_drivers] Error 2

The vm_offset one is called vm_pgoff now - the warnings for
the new style init/exit functions gives the above warnings
is the involved functions are declared static.

Why is that?

-- 
*  Jens Axboe <axboe@image.dk>
*  Linux CD-ROM Maintainer
*  http://www.kernel.dk

--7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="es1371.diff"

--- es1371.c~ Sun Oct 31 01:48:46 1999 +++ es1371.c Sun Oct 31 01:58:58 1999 @@ -1894,7 +1894,7 @@ db = &s->dma_adc; } else return -EINVAL; - if (vma->vm_offset != 0) + if (vma->vm_pgoff != 0) return -EINVAL; size = vma->vm_end - vma->vm_start; if (size > (PAGE_SIZE << db->buforder)) @@ -2415,7 +2415,7 @@ return -EINVAL; if ((ret = prog_dmabuf_dac1(s)) != 0) return ret; - if (vma->vm_offset != 0) + if (vma->vm_pgoff != 0) return -EINVAL; size = vma->vm_end - vma->vm_start; if (size > (PAGE_SIZE << s->dma_dac1.buforder)) @@ -3230,7 +3230,7 @@ } -static int __init init_es1371(void) +int __init init_es1371(void) { struct pci_dev *pcidev = NULL; int index = 0; @@ -3256,7 +3256,7 @@ return 0; } -static void __exit cleanup_es1371(void) +void __exit cleanup_es1371(void) { struct es1371_state *s;

--7AUc2qLy4jB3hD7Z--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/