Re: 2.3.25pre2: drivers/sound/es1371.c broken

Jeff Garzik (jgarzik@mandrakesoft.com)
Sat, 30 Oct 1999 20:42:45 -0400

Jens Axboe wrote:
> The vm_offset one is called vm_pgoff now - the warnings for
> the new style init/exit functions gives the above warnings
> is the involved functions are declared static.
>
> Why is that?

Because there is no need for them to be non-static. Look at
include/linux/init.h...

> ------------------------------------------------------------------------
>
> es1371.diffName: es1371.diff
> Type: Plain Text (text/plain)

The second part of this patch is wrong.

When applying the s/offset/pgoff/ part of the patch, I do not get any
warnings at all (w/ egcs 1.1.2):

as a module:

make[2]: Entering directory
`/usr/local/home/jgarzik/cvs/linux_2_3/drivers/sound'
gcc -D__KERNEL__ -I/usr/local/home/jgarzik/cvs/linux_2_3/include -Wall
-Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe
-fno-strength-reduce -DCPU=586 -march=i586 -DMODULE
-DCONFIG_SOUND_SBDSP -DCONFIG_SOUND_UART401 -c -o es1371.o es1371.c
echo drivers/sound/

in the kernel:

make[3]: Entering directory
`/usr/local/home/jgarzik/cvs/linux_2_3/drivers/sound'
gcc -D__KERNEL__ -I/usr/local/home/jgarzik/cvs/linux_2_3/include -Wall
-Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe
-fno-strength-reduce -DCPU=586 -march=i586 -DCONFIG_SOUND_SBDSP
-DCONFIG_SOUND_UART401 -c -o es1371.o es1371.c
gcc -D__KERNEL__ -I/usr/local/home/jgarzik/cvs/linux_2_3/include -Wall
-Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe
-fno-strength-reduce -DCPU=586 -march=i586 -DCONFIG_SOUND_SBDSP
-DCONFIG_SOUND_UART401 -c -o audio.o audio.c

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/