Re: 2.2: skb->mac.ethernet always valid pointer?

Paul Rusty Russell (Paul.Russell@rustcorp.com.au)
Sun, 26 Sep 1999 11:13:36 +0930


In message <199909251859.WAA16656@ms2.inr.ac.ru> you write:
> What's about dumping in output chain... It is non-sense.
> I am sorry, it is better not to make this. This area will replicate
> addresses of some earlier allocated packet with 100% of probability
> and you may difame innocent people.

You're right. It'll have to be conditional: if output chain,
don't print mac address.

Jens, this means passing the chain arg through ip_fw_domatch to
dump_packet, and having it dump source mac address iff chain !=
IP_FW_OUTPUT_CHAIN (if !testing, chain must be a built-in, and
dump_packet only gets called if !testing, so must be INPUT or
FORWARD).

Rusty.

--
Hacking time.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/