Re: [patch] to include/linux/lp.h

kissg@sztaki.hu
Tue, 08 Jun 1999 09:21:32 +0200 (MET DST)

> > This patch is mostly cosmetical.
> > Curently the 'interrupt enable' bit of parallel port has a symbol but
> > it is mixed with the comment of the missing 'direction' bit.
> >
> > Affected versions: 2.X, 1.3.18+
>
> This patch shouldn't be applied to 2.2 or onwards, since those symbols now
> live in parport.h.

Yes, it should not be, but MAY be.
The lp.h contains the incorrect line yet:

#define LP_PINTEN 0x10 /* high to read data in or-ed with data out */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^???

(At least in 2.2.7)

And IMHO if there is one duplicated symbol there may be two also.

Gabor

----
Ooops! I've just understood, that this comment is totally bad even for
the 0x20 bit. If bit 0x20 is 0 the input and output will be AND-ed.
Otherwise the output drives does high-impedance state and does not
interfere with the input.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/