Re: [patch]: adding nls to smbfs

Michael H. Warfield (mhw@wittsend.com)
Mon, 17 May 1999 09:37:11 -0400 (EDT)


Urban Widmark enscribed thusly:

> Hello again

> (Volker, are you out there?)

> This is a patch to make smbfs aware of differences in "codepages" (charset
> encodings). It makes swedish characters exported by a smb server appear as
> they should on an iso8859-1 display (terminal?). Chances are that it also
> works for other encodings, possibly even utf8 ...
> I need help testing this with various encodings, for stability, etc.

> The codepages are changed by changing some defines, or by patching samba
> (smbmount & smbmnt) to handle 2 new arguments. The later requires you to
> patch your kernel and change a define in include/linux/smb_mount.h (it's
> experimental, it's not supposed to be easy :), *before* recompiling samba.

> (Michael, I sent you this < 1week ago for comments on the samba part.
> Either you've been busy or it was lost in your elm/2.2.8/buffer.c disk
> corruption, anyway here you have it again.)

I got your earlier message and was following up on a couple of
other angles. I've also got patches from "Artem V. Ryabov" <artem@abak.ru>
to do this as well. So it looks like we've got two efforts going on. You
may want to contact him and compare notes. I'm adding him in on this
message as well in case he's not actively reading linux-kernel.

Volker no longer maintains either smbfs or smbmount. I maintain
smbmount in Samba and Bill Hawes is suppose to be maintaining smbfs in the
kernel (at least the version in 2.2.x). Unfortunately, I have not been able
to contact Bill in over six months. Linus told me that he thought Bill was
only going to do some ongoing support maintenance, and not do any active
development maintenance. At LinuxWorld Expo, I spoke with Peter Anvin and
he said he would talk to Bill and find out what the story is. I haven't
heard back from him since.

If anyone knows how to contact Bill, please rattle his cage! We
need to at least know, yeah or nay, if he wants to be handling this!

> What the patch does is that it makes smbfs convert from the remote charset
> to the local when reading, and convert back when sending requests to the
> server. Nicer would perhaps be to keep a copy of both filenames (but there
> is a lot of copying and string reversing anyway, this shouldn't be too
> much of a performance hit).

> Patch against 2.2.9 attached (known to work with 2.2.7, 2.2.8, 2.3.3,
> +- some offsets)

Let me look this over and reconcile it with the patch I got from
Russia. You both should now have each other's address, so you can look
over each other's efforts.

> /Urban

Mike

-- 
 Michael H. Warfield    |  (770) 985-6132   |  mhw@WittsEnd.com
  (The Mad Wizard)      |  (770) 925-8248   |  http://www.wittsend.com/mhw/
  NIC whois:  MHW9      |  An optimist believes we live in the best of all
 PGP Key: 0xDF1DD471    |  possible worlds.  A pessimist is sure of it!

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/