Re: mv operation doesn't work anymore in VFAT filesystem (followup)

Tom Eastep (eastep@loc1.tandem.com)
Sat, 23 Jan 1999 05:37:07 +0000


This is a multi-part message in MIME format.
--------------675E0766BC4212A056B23CF8
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Alex Buell wrote:
>
> Further from my previous email, here's an strace from mv
>
> stat("testing", 0xbffff730) = -1 ENOENT (No such file or directory)
> lstat("autoexec.bat", {st_mode=S_IFREG|0660, st_size=111, ...}) = 0
> lstat("testing", 0x804bb28) = -1 ENOENT (No such file or directory)
> rename("autoexec.bat", "testing") = -1 ENOENT (No such file or directory)

The attached patch which fixes this problem was posted several days
ago...

-Tom

-- 
Tom Eastep
Compaq Computer Corporation
Enterprise Computing Group
Tandem Division
tom.eastep@compaq.com
--------------675E0766BC4212A056B23CF8
Content-Type: text/plain; charset=us-ascii;
 name="patch-vfat"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="patch-vfat"

--- linux-old/fs/vfat/namei.c Thu Jan 21 09:59:22 1999 +++ linux/fs/vfat/namei.c Thu Jan 21 10:06:13 1999 @@ -1657,9 +1657,9 @@ drop_aliases(new_dentry); } res = vfat_remove_entry(new_dir,&sinfo,new_inode); + if (res) + goto rename_done; } - if (res) - goto rename_done; /* Serious lossage here. FAT uses braindead inode numbers scheme, * so we can't simply cannibalize the entry. It means that we have

--------------675E0766BC4212A056B23CF8 Content-Type: text/x-vcard; charset=us-ascii; name="eastep.vcf" Content-Transfer-Encoding: 7bit Content-Description: Card for Tom Eastep Content-Disposition: attachment; filename="eastep.vcf"

begin:vcard n:Eastep;Tom x-mozilla-html:TRUE org:Compaq Computer Corporation;Tandem Division adr:;;;;;; version:2.1 email;internet:tom.eastep@compaq.com x-mozilla-cpt:;-6528 fn:Tom Eastep end:vcard

--------------675E0766BC4212A056B23CF8--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/