Re: Some little problems with 2.1.129

Ragnar Hojland Espinosa (ragnar@redestb.es)
Mon, 23 Nov 1998 11:22:12 +0100 (CET)


On Mon, 23 Nov 1998, Alex Buell wrote:
> 1) dcron-2.3.3 isn't Y2K compliant. It happens to use %y as a
> parameter to some sscanf/printf stuff, and this only yields 2 digits.
> That particular package needs sorting out. This reminded me to warn
> you to keep an eye out for user land problems of this nature.

It also has a bug. See patch below (2nd main chunk), along with other
little modifications to make it compule under glibc 2.0.10x

-- 
____/|  Ragnar Hojland  (ragnar@lightside.ddns.org)      Fingerprint  94C4B
\ o.O|  _______________________________________________  2F0D27DE025BE2302C
 =(_)= | 7 Diciembre, manifestacion contra Telefonica! | 104B78C56 B72F0822
   U   |  No faltes!!  http://www.internautas.org/7D/) | hkp://keys.pgp.com
        -----------------------------------------------

diff -ruNp dcron-2.3.3.ORIG/crontab.c dcron-2.3.3/crontab.c --- dcron-2.3.3.ORIG/crontab.c Sun Aug 31 09:30:40 1997 +++ dcron-2.3.3/crontab.c Thu Nov 5 21:50:34 1998 @@ -136,7 +136,7 @@ main(int ac, char **av) */ if (chdir(CDir) < 0) { - fprintf(stderr, "cannot change diir to %s: %s\n", CDir, strerror(errno)); + fprintf(stderr, "cannot change dir to %s: %s\n", CDir, strerror(errno)); exit(1); } @@ -201,7 +201,7 @@ main(int ac, char **av) close(fd); rename(path, pas->pw_name); } else { - fprintf(stderr, "unable to create %s/%s\n", CDir, buf); + fprintf (stderr, "unable to create %s/%s: %s", CDir, path, strerror(errno)); } close(repFd); } diff -ruNp dcron-2.3.3.ORIG/subs.c dcron-2.3.3/subs.c --- dcron-2.3.3.ORIG/subs.c Mon Feb 16 20:35:10 1998 +++ dcron-2.3.3/subs.c Thu Nov 5 21:22:25 1998 @@ -15,7 +15,7 @@ Prototype void fdprintf(int fd, const ch Prototype int ChangeUser(const char *user, short dochdir); Prototype void vlog(int level, int fd, const char *ctl, va_list va); Prototype int slog(char *buf, size_t sz, const char *ctl, va_list va, short useDate); -Prototype char *strdup(const char *); +//Prototype char *strdup(const char *); void log9(const char *ctl, ...) @@ -130,7 +130,7 @@ ChangeUser(const char *user, short dochd } return(pas->pw_uid); } - +#if 0 char * strdup(const char *str) { @@ -141,3 +141,4 @@ strdup(const char *str) return(ptr); } +#endif

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/