Re: Problem with SLIP in 2.1.126

David Weinehall (tao@acc.umu.se)
Sat, 7 Nov 1998 17:52:50 +0100 (MET)


On Sat, 7 Nov 1998, Alan Cox wrote:

> > The way I forced 9600baud was to set one moden so that its max
> > and min baud rates were both 9600b. I think this prevented
> > any speed negociation even though the modem at the far end was
> > not constrained. The USR documentation on retraining is vague
> > to put it mildly.
>
> It'll still do error correction but yes
>
> > My conclusion from this is that it is more likely that there
> > is a hang/timeout somewhere in the SLIP handling rather than
> > a modem problem. I have new (56k) USR modems on order in any
>
> Ok. Some other folk with similar problems are putting 2.1.8x as where
> things started to go bizarre. That should help pin it down

After a quick check via the patch-browser on LinuxHQ, I've nailed it down
to either v2.1.86 or v2.1.89 (the only ones with changes in slip; and none
of the v2.1.8x kernels contain any serial changes on the x86 platform).

The change in v2.1.86 is one single line;

diff -u --recursive --new-file v2.1.85/linux/drivers/net/slip.c
linux/drivers/net/slip.c
@@ -518,7 +518,7 @@
sl_lock(sl);
sl->tx_bytes+=skb->len;
sl_encaps(sl, skb->data, skb->len);
- dev_kfree_skb(skb, FREE_WRITE);
+ dev_kfree_skb(skb);
}
return 0;
}

And unless this is the problem (doesn't look that way), the problem is in
v2.1.89... That is, if it really was the v2.1.8x kernels that introduced
the problem...

/David Weinehall

-- 
>--------------------------------------------------------------------<
>                                                                    <
>      *****..           Tao of TRIAD                   *****..      <
>   ****.........       ______________               ****.........   <
>  ****.....***...                                  ****.....***...  <
> ****......***....     David Weinehall            ****......***.... <
> ******...........     V Varmvattnet 63           ******........... <
> ***********......     S - 922 67  TAVELSJO       ***********...... <
> ****...******....     SWEDEN                     ****...******.... <
>  ***...*****....                                  ***...*****....  <
>   *********....       Tel # : +46(0)90 - 604 10    *********....   <
>      **.....          E-mail: tao@acc.umu.se          **.....      <
>               Home-page: http://www.acc.umu.se/~tao/               <
>--------------------------------------------------------------------<

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/