Re: [patch] my latest oom stuff
Linus Torvalds (torvalds@transmeta.com)
Sat, 24 Oct 1998 18:46:42 -0700 (PDT)
On Sun, 25 Oct 1998, Andrea Arcangeli wrote:
>
> And I don' t understand why you continue to use this way to allocate
> memory:
>
> __get_free_pages()
> {
> page = get_the_page();
>
> if (page)
> return page;
> else {
> free_memory_and_wait();
> return OOM;
> }
> }
>
> Why we are freeing memory if we are going to fail for sure? The
> right place to wakeup kswapd is after a process is been killed and not
> before, I think.
Ehh.. Why would the process be killed? What about anything that is _not_
fatal?
Your changes to __get_free_page() was one of the reasons I didn't want to
apply the patches.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/