Re: patch-2.1.117 adds bad ide_xlate_1024()

Mark Lord (mlord@pobox.com)
Sat, 22 Aug 1998 20:00:40 +0000


This is a multi-part message in MIME format.
--------------95A9CEADA233989807418D1E
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Andries.Brouwer@cwi.nl wrote:
>
> In patch-2.1.117 there is the fragment
> ---------------------------------------------------------------
> --- v2.1.115/linux/drivers/block/genhd.c Thu Aug 6 14:06:31 1998
> +++ linux/drivers/block/genhd.c Sun Aug 16 11:48:40 1998
...
> a very bad idea.
> It decides that all disks should use a translated geometry. Why?

The update was supposed to only affect LARGE drives that were
not otherwise accounted for by a translation scheme, an extremely
common case (any time a new drive is added to a system).

But the update was missing one line, that should fix most/all complaints
(update attached).

-- 
mlord@pobox.com
--------------95A9CEADA233989807418D1E
Content-Type: text/plain; charset=us-ascii;
 name="ide-2.1.117+.pat1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ide-2.1.117+.pat1"

--- linux/drivers/block/genhd.c.orig Tue Aug 18 21:34:07 1998 +++ linux/drivers/block/genhd.c Sat Aug 22 15:53:48 1998 @@ -421,7 +421,7 @@ && (q->sector & 63) == 1 && (q->end_sector & 63) == 63) { unsigned int heads = q->end_head + 1; - if (heads == 32 || heads == 64 || heads == 128 || heads == 255) { + if (heads == 16 || heads == 32 || heads == 64 || heads == 128 || heads == 255) { (void) ide_xlate_1024(dev, heads, " [PTBL]"); xlate_done = 1;

--------------95A9CEADA233989807418D1E--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html