Re: linux-2.1.115 on alpha: bug in memsetw_io (or memset_c_io)

Richard Henderson (rth@dot.cygnus.com)
Sat, 8 Aug 1998 19:47:50 -0700

On Sat, Aug 08, 1998 at 05:37:40PM -0700, Richard Henderson wrote:
> Martin, I think it is a bug in the console code that an unaligned
> address was ever given to scr_memsetw. The characters in video
> memory are always aligned, therefore we must have an off-by-one bug.

Urk, no, it's my bad. Sorry about that.

r~

Index: arch/alpha/lib/io.c
===================================================================
RCS file: /home/rth/CVSROOT/linux/arch/alpha/lib/io.c,v
retrieving revision 1.3
diff -u -p -r1.3 io.c
--- io.c 1998/07/24 05:40:56 1.3
+++ io.c 1998/08/09 02:39:32
@@ -481,12 +481,12 @@ void _memset_c_io(unsigned long to, unsi
}
count += 8;
}
- if (count >= 4 && (to & 4)) {
+ if (count >= 4) {
writel(c, to);
to += 4;
count -= 4;
}
- if (count >= 2 && (to & 2)) {
+ if (count >= 2) {
writew(c, to);
to += 2;
count -= 2;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html