2.1.110pre1 - 1 Gig memory trap is nasty + FIX

Alan Cox (alan@lxorguk.ukuu.org.uk)
Sat, 18 Jul 1998 20:10:23 +0100 (BST)

This little tweak is going to catch people out badly when they follow the
instructions elsewhere in the kernel for going to 2Gig of memory, not

diff -u --recursive --new-file v2.1.109/linux/arch/i386/kernel/setup.c linux/arch/i386/kernel/setup.c
--- v2.1.109/linux/arch/i386/kernel/setup.c Thu Jul 16 18:09:23 1998
+++ linux/arch/i386/kernel/setup.c Fri Jul 17 10:34:54 1998
@@ -147,6 +147,8 @@
memory_end = memory_alt_end;
}
#endif
+ if (memory_end > (1024-64)*1024*1024)
+ memory_end = (1024-64)*1024*1024;
memory_end &= PAGE_MASK;

Surely it should be

#define VMALLOC_POOL_SPACE (64<<20) /* 64Mb */

and then use

if (memory_end + VMALLOC_POOL_SPACE < 0xFFFFFFFF-PAGE_OFFSET)

That way it adapts properly to the settings in page.h

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html