OK - I put zero intellectual effort into it and reworked yours for
2.0.25. It's compiling now. Yep - done. I'll send it later or tomorrow
if it does anything right (I'll have to play with the proc entry struct, I
guess).
I noticed that your patch adds PROC_CONFIG _before_ the end of the
enumerated type. IMO that's a maintenance no-no, so I moved it. Your
C code was very expert so you may well know something I don't here!
I also didn't really follow the way that makeproconfig.sh,
makeproconfig.c and various other things all interacted. You may want
to simplify that .. I was getting lost. All you want is to generate
the kernel/config.c file, so why isn't a single shell script good
enough? The Makefile now goes out of its way to call the configure
script exactly once with new arguments -di (not -d) and you inserted
an extra trap in readln of Configure to deal with it, while I didn't
grok what it did. All that felt like unnecessary complication! Maybe
you could add in your reply as comments to the changes? I'd like that.
Then we have to add #ifdef CONFIG_CONFIG everywhere (;-).
Peter ptb@it.uc3m.es
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu