Re: Patch for 2.1.20 to try: "kernel environment"

Matthias Urlichs (smurf@noris.de)
15 Jan 1997 07:45:13 +0100


In linux.dev.kernel, article <5b43n6$pgn@nntp.Stanford.EDU>,
dhinds@hyper.stanford.edu (David Hinds) writes:
> Matthias Urlichs (smurf@work.smurf.noris.de) wrote:
> : In linux.dev.kernel, article <5aoroq$1al@nntp.Stanford.EDU>,
> : dhinds@hyper.stanford.edu (David Hinds) writes:
> : > --- linux/fs/proc/array.c.orig Wed Jan 1 22:08:20 1997
> : > +++ linux/fs/proc/array.c Fri Jan 3 23:54:36 1997
> : > ...
> : > + len += sprintf(buffer+len, "%s\n", *p);
> : > ...
>
> : I would use \0 instead of \n here. /proc/*/environ does the same thing.
>
> I did notice that /proc/*/environ (and cmdline) use null terminated
> strings. I have one question: why?? It seems to me that this only

Because command lines and environment strings can and do contain linefeeds.
$IFS, for instance.

-- 
If you are doing something wrong, you will do it badly.
-- 
Matthias Urlichs         \  noris network GmbH  /  Xlink-POP Nürnberg 
Schleiermacherstraße 12   \   Linux+Internet   /   EMail: urlichs@noris.de
90491 Nürnberg (Germany)   \    Consulting+Programming+Networking+etc'ing
   PGP: 1024/4F578875   1B 89 E2 1C 43 EA 80 44  15 D2 29 CF C6 C7 E0 DE
       Click <A HREF="http://info.noris.de/~smurf/finger">here</A>.    42