Re: [PATCH] vhost/net: bound the count of VHOST_SET_FEATURES_ARRAY

From: Michael S. Tsirkin

Date: Sun Nov 22 2026 - 09:25:55 EST


On Sun, Nov 22, 2026 at 07:09:19AM -0500, Hengyu Liang wrote:
> Commit 333c515d1896 ("vhost-net: allow configuring extended features")
> added VHOST_SET_FEATURES_ARRAY. The ioctl reads the number of feature
> words from user space and checks that every word above the supported
> ones is zero, one word at a time in a loop.
>
> However, the loop has no upper bound and no scheduling point. As of now,
> a caller can pass a count of U64_MAX and a pointer into a large
> zero-filled mapping. The ioctl then stays in the kernel for as long as
> the mapping is readable, and a fatal signal is not handled until it
> ends. On a v6.18 debug kernel booted with preempt=none, two such calls
> from a non-root user, each on a 4 GiB mapping, froze a 2-CPU VM for
> 56 s with soft lockup reports.
>
> Interfaces that take an extensible structure from user space limit it
> to one page (openat2, clone3, sched_setattr).
>
> On a KASAN kernel with a 1 GiB mapping: before commit 333c515d1896
> ("vhost-net: allow configuring extended features"), the ioctl does not
> exist and the call fails with EPERM at once. After that commit, it
> fails with EFAULT after 26.0 s. With this patch, it fails with E2BIG at
> once. A reproducer is available on request.
>
> This patch will reject counts above one page of words (512 on a 4 KiB
> page, or 32768 feature bits; 128 are defined today) before the walk
> starts.
>
> Fixes: 333c515d1896 ("vhost-net: allow configuring extended features")
> Cc: stable@xxxxxxxxxxxxxxx # v6.17+
> Signed-off-by: Hengyu Liang <hengyul@xxxxxxxxxx>
> ---
> I found this while comparing the behavior of different kernel versions.
> I used an LLM to analyze the problem and to draft the patch and this
> message, and I analyzed the result myself.
>
> Tested on the vhost tree at 44293796526f with KASAN and lockdep: counts
> of 0, 2, 3 and 512 words still succeed, a nonzero word above the
> supported ones still gives EOPNOTSUPP, and VHOST_GET_FEATURES_ARRAY is
> unchanged.
> drivers/vhost/net.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
> index 631855064b3d..22e06b44d2ed 100644
> --- a/drivers/vhost/net.c
> +++ b/drivers/vhost/net.c
> @@ -1795,6 +1795,8 @@ static long vhost_net_ioctl(struct file *f, unsigned int ioctl,
> case VHOST_SET_FEATURES_ARRAY:
> if (copy_from_user(&count, featurep, sizeof(count)))
> return -EFAULT;
> + if (count > PAGE_SIZE / sizeof(u64))
> + return -E2BIG;
>
> virtio_features_zero(all_features);
> argp += sizeof(u64);

????
this is followed by:

virtio_features_zero(all_features);
argp += sizeof(u64);
copied = min(count, (u64)VIRTIO_FEATURES_U64S);
if (copy_from_user(all_features, argp, copied * sizeof(u64)))
return -EFAULT;

copies at most 8 bytes.


did you test that this patch actually helps anything?


> base-commit: 44293796526f4343639f87b2acc53811c78b5d54
> --
> 2.53.0