Re: [PATCH 4/5] nvme: decode the FDP Get Features result as a dword

From: shao.mingyin

Date: Sun Nov 22 2026 - 09:23:02 EST


Hi Christoph,

> With this struct nvme_fdp_config becomes unused, so we might as well
> drop it.

Dropped in v2; the FDPCFG_FDPE definition stays.

> Also can you look into the Sashiko found existing issue and fix it in
> a separate patch while you're at it?

I looked, and the buffer is initialized before hdr.sze is read. hdr is a
stack object, so nvme_submit_sync_cmd() -> blk_rq_map_kern() takes the
bio_copy_kern() path: the pages come from
alloc_page(GFP_NOIO | __GFP_ZERO | gfp_mask), and
bio_copy_kern_endio_read() copies every bvec of the full length back into
hdr before the command returns. A short transfer therefore leaves
zeroes, not stale stack. There is nothing to fix, so no separate patch.

Thanks,
Shao