Re: [RFC PATCH 2/3] platform: lenovo: add WMI hotkeys driver

From: Jackie Dong

Date: Thu Nov 19 2026 - 07:12:45 EST


On Wed, 2026-11-18 at 18:29 -0800, David Cemin wrote:
> Hi Jackie,
>
> Thanks for the review and the Reviewed-by on patch 1.
>
> On merging wmi-hotkeys.c with wmi-hotkey-utilities.c: I kept them
> separate because they are different interfaces. wmi-hotkey-
> utilities.c
> drives the method GUID (microphone mute LED, Fn lock state), while
> wmi-hotkeys.c owns the event GUIDs and only turns events into input
> reports; the notifier chain is how the two sides meet, and ideapad-
> laptop
> uses it. If the maintainers prefer a single file the merge is
> mechanical
> and I am happy to do it in v3; otherwise I would keep the method and
> event
> sides apart, as the other Lenovo WMI drivers do.
>
> v2 is out as 20261119022719.3089229-1-dcemin@xxxxxxxxxx and includes
> your tag.
>
> Thanks,
> David
Hi David,
I agree that wmi-hotkeys.c and wmi-hotkey-utilities.c are different
interfaces. But I stick on my point that the two file names are
similar and easy to confuse for developers and maintainer.
I suggest another file name should be a solution, such as wmi-hotkeys-
switches.c, wmi-FnKey-event-report.c, FYR.

Regards,

Jackie