Re: [RFC PATCH 2/3] platform: lenovo: add WMI hotkeys driver
From: David Cemin
Date: Wed Nov 18 2026 - 21:29:43 EST
Hi Jackie,
Thanks for the review and the Reviewed-by on patch 1.
On merging wmi-hotkeys.c with wmi-hotkey-utilities.c: I kept them
separate because they are different interfaces. wmi-hotkey-utilities.c
drives the method GUID (microphone mute LED, Fn lock state), while
wmi-hotkeys.c owns the event GUIDs and only turns events into input
reports; the notifier chain is how the two sides meet, and ideapad-laptop
uses it. If the maintainers prefer a single file the merge is mechanical
and I am happy to do it in v3; otherwise I would keep the method and event
sides apart, as the other Lenovo WMI drivers do.
v2 is out as 20261119022719.3089229-1-dcemin@xxxxxxxxxx and includes
your tag.
Thanks,
David