Re: [PATCH 2/2] zonefs: ignore RLIMIT_FSIZE above LLONG_MAX in zonefs_write_check_limits()

From: Damien Le Moal

Date: Wed Nov 18 2026 - 19:44:43 EST


On 2026/11/17 9:31, Ding Feng wrote:
> zonefs_write_check_limits() follows generic_write_check_limits() and
> has the same problem: it stores rlimit(RLIMIT_FSIZE), an unsigned long,
> in a loff_t, so a soft limit between 2^63 and RLIM_INFINITY is negative
> and every write fails with -EFBIG and raises SIGXFSZ.
>
> Keep the limit unsigned and apply it only when it is at most LLONG_MAX,
> as the generic helper now does.
>
> Fixes: ebfd68cd0c1e ("zonefs: Fix O_APPEND async write handling")
> Cc: stable@xxxxxxxxxxxxxxx
> Assisted-by: Claude:claude-opus-5-5 Frama-C
> Signed-off-by: Ding Feng <dingf3ng@xxxxxxxxx>
> ---
> fs/zonefs/file.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/fs/zonefs/file.c b/fs/zonefs/file.c
> index 319d950..ea9582e 100644
> --- a/fs/zonefs/file.c
> +++ b/fs/zonefs/file.c
> @@ -399,15 +399,16 @@ static loff_t zonefs_write_check_limits(struct file *file, loff_t pos,
> {
> struct inode *inode = file_inode(file);
> struct zonefs_zone *z = zonefs_inode_zone(inode);
> - loff_t limit = rlimit(RLIMIT_FSIZE);
> + unsigned long limit = rlimit(RLIMIT_FSIZE);
> loff_t max_size = z->z_capacity;
>
> - if (limit != RLIM_INFINITY) {
> - if (pos >= limit) {
> + /* No file position reaches a limit above LLONG_MAX. */
> + if (limit != RLIM_INFINITY && limit <= LLONG_MAX) {

As the kernel test robot pointed out, limit <= LLONG_MAX is always true on
32-bits arch because limit is an unsigned long. So we need limit to be an
unsigned long long I think. Same thing on patch 1.

I am pulling this patch until this is fixed.

> + if (pos >= (loff_t)limit) {
> send_sig(SIGXFSZ, current, 0);
> return -EFBIG;
> }
> - count = min(count, limit - pos);
> + count = min(count, (loff_t)limit - pos);
> }
>
> if (!(file->f_flags & O_LARGEFILE))


--
Damien Le Moal
Western Digital Research